Skip to content

Don't output to stdout from lib non-interactive methods [failure unrelated]

Ramya Authappan requested to merge github/fork/cirosantilli/rm-lib-stdout into master

Created by: cirosantilli

It pollutes the test output too much.

This only affects methods which are called primarily from GitLab's normal operation: lib commands that are triggered by command like actions like Rake tasks were not changed.

Just check for example https://semaphoreapp.com/gitlabhq/gitlabhq/branches/pull-request-8233/builds/1: there are parts of the RSpec where you see nothing but messages like:

Initialized empty Git repository in /home/runner/gitlabhq/tmp/tests/repositories/group336/gitlab.git/

If anyone misses the messages, please patch to log them instead. This can be done with popen as well.

Merge request reports