Skip to content

Fix admin_all_repo behaviour in Gitlabhq::Gitolite

Ramya Authappan requested to merge github/fork/codec/gitolite-owner-name into master

Created by: codec

admin_all_repo expects that gitlab is the only user with access to gitolite-admin.

This may break on some installations Having more than just the gitlab user in the gitolite-admin configuration seems to be possible, as the gitolite-admin configuration will always be kept as is (where other repos will just be rewritten from the database).

Reproduce Pull your gitolite-admin repository and change conf/gitolite.conf to list another user in RW+ before gitlab, i.e.

repo    gitolite-admin
  RW+                            = foobar gitlab

Now run gitlab:app:enable_automerge and get rejected by gitolite (for user gitlab).

Merge request reports