Skip to content

Commit message textareas have 72 char mark line.

Ramya Authappan requested to merge github/fork/booktree/72-char-commit-msg into master

Created by: cirosantilli

Fixes ACCEPTING MR at: http://feedback.gitlab.com/forums/176466-general/suggestions/5337507-show-72-character-mark-in-commits?tracking_code=284b0e5fd832f6885a68d90447c08d2a

All textareas that take a commit message now have the same monospace font in which they are shown under the commits tab, and a 72 character width vertical marker line.

I have only found commit message textareas in the following places:

  • new, edit and remove file from web interface views.
  • merge request custom commit message

Please notify me if there are any more of them.

screenshots

Edit file:

screenshot from 2014-02-22 18 48 18 edit

New file is analogous.

The remove popup had to be made wider because it did not have place for 72 characters before:

screenshot from 2014-02-22 20 23 08 rm

Custom MR commit message:

screenshot from 2014-02-22 18 52 21 mr

doubts

How to use exactly the same Bootstrap values of textarea.form-control padding-left for .max-width-marker left?

I could not find it, so I just set hardcoded the current Bootstrap value of 12px for both the padding and the left.

This way it will never break, but it will not evolve automatically if the page style is modified.

One possibility to solve this is to set all missing values ourselves in our SASS via variables to their current values so that those variables can be used in other places.

Merge request reports